From 3ccd4d07e98c6bf8eb962b4ca7099369a9d65dff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niko=20K=C3=B6ser?= Date: Mon, 1 Feb 2021 10:34:06 +0100 Subject: [PATCH] fix: accidentally overwritten error value In function _cli.send_ the named return value 'err' gets accidentally overwritten in the deferred anonymous function that removes the files/directories. Renamed the error variable inside the deferred function so that it does not overwrite the original error anymore. Closes #296 --- src/cli/cli.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/cli/cli.go b/src/cli/cli.go index 0c5bc2b..b70e1f0 100644 --- a/src/cli/cli.go +++ b/src/cli/cli.go @@ -223,9 +223,9 @@ func send(c *cli.Context) (err error) { return } defer func() { - err = os.Remove(fnames[0]) - if err != nil { - log.Error(err) + e := os.Remove(fnames[0]) + if e != nil { + log.Error(e) } }() } else if c.String("text") != "" { @@ -234,9 +234,9 @@ func send(c *cli.Context) (err error) { return } defer func() { - err = os.Remove(fnames[0]) - if err != nil { - log.Error(err) + e := os.Remove(fnames[0]) + if e != nil { + log.Error(e) } }()