From e0303cff4ec3e478c7bd28066cb97fdf37787f7a Mon Sep 17 00:00:00 2001 From: Tom Piccirello <8296030+Piccirello@users.noreply.github.com> Date: Sun, 3 May 2020 05:22:46 -0700 Subject: [PATCH] Drop leading zero ('0') from plugin minor version (#135) Four search plugins specify a leading zero in their minor version (e.g. `jackett: 3.03`). This leading zero isn't reflected in the qBittorrent GUI or the Web UI. This is because qBittorrent's version display logic [0] effectively drops the leading zero when calling `QString::number()`. Given that semver rule 2 [1] expressely forbids leading zeros, I don't consider qBittorrent's implementation a bug. Thus, we might as well drop the leading zero from those version numbers. [0] https://github.com/qbittorrent/qBittorrent/blob/8999f1a8daaf293480bb5c6dd36a4a6c260adecb/src/base/utils/version.h#L115,L129 [1] https://semver.org/#spec-item-2 --- nova/engines/jackett.py | 2 +- nova/engines/leetx.py | 2 +- nova/engines/legittorrents.py | 2 +- nova/engines/limetorrents.py | 2 +- nova/engines/versions.txt | 8 ++++---- nova3/engines/jackett.py | 2 +- nova3/engines/leetx.py | 2 +- nova3/engines/legittorrents.py | 2 +- nova3/engines/limetorrents.py | 2 +- nova3/engines/versions.txt | 8 ++++---- 10 files changed, 16 insertions(+), 16 deletions(-) diff --git a/nova/engines/jackett.py b/nova/engines/jackett.py index 5d3a518..6d29ff4 100644 --- a/nova/engines/jackett.py +++ b/nova/engines/jackett.py @@ -1,4 +1,4 @@ -#VERSION: 3.03 +#VERSION: 3.4 # AUTHORS: Diego de las Heras (ngosang@hotmail.es) # CONTRIBUTORS: ukharley # hannsen (github.com/hannsen) diff --git a/nova/engines/leetx.py b/nova/engines/leetx.py index 68fc5f5..3380082 100644 --- a/nova/engines/leetx.py +++ b/nova/engines/leetx.py @@ -1,4 +1,4 @@ -#VERSION: 2.01 +#VERSION: 2.2 #AUTHORS: Vikas Yadav (https://github.com/v1k45 | http://v1k45.com) #CONTRIBUTORS: Diego de las Heras (ngosang@hotmail.es) diff --git a/nova/engines/legittorrents.py b/nova/engines/legittorrents.py index d9be445..50480f4 100644 --- a/nova/engines/legittorrents.py +++ b/nova/engines/legittorrents.py @@ -1,4 +1,4 @@ -#VERSION: 2.03 +#VERSION: 2.4 # AUTHORS: Christophe Dumez (chris@qbittorrent.org) # Douman (custparasite@gmx.se) diff --git a/nova/engines/limetorrents.py b/nova/engines/limetorrents.py index 5acd607..387cffd 100644 --- a/nova/engines/limetorrents.py +++ b/nova/engines/limetorrents.py @@ -1,4 +1,4 @@ -#VERSION: 4.04 +#VERSION: 4.5 # AUTHORS: Lima66 # CONTRIBUTORS: Diego de las Heras (ngosang@hotmail.es) diff --git a/nova/engines/versions.txt b/nova/engines/versions.txt index cd71cf9..edf5111 100644 --- a/nova/engines/versions.txt +++ b/nova/engines/versions.txt @@ -1,8 +1,8 @@ eztv: 1.10 -jackett: 3.03 -leetx: 2.01 -legittorrents: 2.03 -limetorrents: 4.04 +jackett: 3.4 +leetx: 2.2 +legittorrents: 2.4 +limetorrents: 4.5 piratebay: 2.20 rarbg: 2.12 torlock: 2.1 diff --git a/nova3/engines/jackett.py b/nova3/engines/jackett.py index 5d3a518..6d29ff4 100644 --- a/nova3/engines/jackett.py +++ b/nova3/engines/jackett.py @@ -1,4 +1,4 @@ -#VERSION: 3.03 +#VERSION: 3.4 # AUTHORS: Diego de las Heras (ngosang@hotmail.es) # CONTRIBUTORS: ukharley # hannsen (github.com/hannsen) diff --git a/nova3/engines/leetx.py b/nova3/engines/leetx.py index 68fc5f5..3380082 100644 --- a/nova3/engines/leetx.py +++ b/nova3/engines/leetx.py @@ -1,4 +1,4 @@ -#VERSION: 2.01 +#VERSION: 2.2 #AUTHORS: Vikas Yadav (https://github.com/v1k45 | http://v1k45.com) #CONTRIBUTORS: Diego de las Heras (ngosang@hotmail.es) diff --git a/nova3/engines/legittorrents.py b/nova3/engines/legittorrents.py index dae9bf7..f61ec87 100644 --- a/nova3/engines/legittorrents.py +++ b/nova3/engines/legittorrents.py @@ -1,4 +1,4 @@ -#VERSION: 2.03 +#VERSION: 2.4 # AUTHORS: Christophe Dumez (chris@qbittorrent.org) # Douman (custparasite@gmx.se) diff --git a/nova3/engines/limetorrents.py b/nova3/engines/limetorrents.py index 5acd607..387cffd 100644 --- a/nova3/engines/limetorrents.py +++ b/nova3/engines/limetorrents.py @@ -1,4 +1,4 @@ -#VERSION: 4.04 +#VERSION: 4.5 # AUTHORS: Lima66 # CONTRIBUTORS: Diego de las Heras (ngosang@hotmail.es) diff --git a/nova3/engines/versions.txt b/nova3/engines/versions.txt index cd71cf9..edf5111 100644 --- a/nova3/engines/versions.txt +++ b/nova3/engines/versions.txt @@ -1,8 +1,8 @@ eztv: 1.10 -jackett: 3.03 -leetx: 2.01 -legittorrents: 2.03 -limetorrents: 4.04 +jackett: 3.4 +leetx: 2.2 +legittorrents: 2.4 +limetorrents: 4.5 piratebay: 2.20 rarbg: 2.12 torlock: 2.1