From 55186d162a4ccdd5e10aa0927622c72acc70a5cf Mon Sep 17 00:00:00 2001 From: windingwind Date: Fri, 5 May 2023 16:24:16 +0800 Subject: [PATCH] add: warning when workspace note is not set --- addon/chrome/locale/en-US/addon.properties | 5 +++-- addon/chrome/locale/zh-CN/addon.properties | 5 +++-- src/modules/workspace/content.ts | 7 +++++-- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/addon/chrome/locale/en-US/addon.properties b/addon/chrome/locale/en-US/addon.properties index 3d69c1b..e5fcf09 100644 --- a/addon/chrome/locale/en-US/addon.properties +++ b/addon/chrome/locale/en-US/addon.properties @@ -4,7 +4,7 @@ menuItem.setMainNote=As Workspace Note menuItem.exportNote=Export Note menuEdit.insertTemplate=Insert Template to Workspace Note -menuEdit.exportTemplate=Export Template... +menuEdit.exportTemplate=Export Template to File... menuEdit.templateEditor=Template Editor menuTools.syncManager=Sync Manager @@ -100,8 +100,9 @@ editor.toolbar.settings.previewInWorkspace=Preview in Workspace editor.toolbar.settings.insertTemplate=Insert Template to Cursor Line editor.toolbar.settings.copyLink=Copy Note Link editor.toolbar.settings.openParent=Open Attachment -editor.toolbar.settings.export=Export Note... +editor.toolbar.settings.export=Export Current Note... editor.toolbar.settings.refreshSyncing=Sync Now alert.notValidCollectionError=Please select a valid collection. alert.notValidParentItemError=No valid parent item. +alert.notValidWorkspaceNote=Workspace note is not set. Create one? diff --git a/addon/chrome/locale/zh-CN/addon.properties b/addon/chrome/locale/zh-CN/addon.properties index 9cddd51..2a7c4f4 100644 --- a/addon/chrome/locale/zh-CN/addon.properties +++ b/addon/chrome/locale/zh-CN/addon.properties @@ -4,7 +4,7 @@ menuItem.setMainNote=设为工作区主笔记 menuItem.exportNote=导出笔记 menuEdit.insertTemplate=插入模板到工作区笔记 -menuEdit.exportTemplate=导出模板... +menuEdit.exportTemplate=导出模板到文件... menuEdit.templateEditor=模板编辑器 menuTools.syncManager=同步管理器 @@ -100,8 +100,9 @@ editor.toolbar.settings.previewInWorkspace=在工作区预览 editor.toolbar.settings.insertTemplate=插入模板到光标行 editor.toolbar.settings.copyLink=复制笔记链接 editor.toolbar.settings.openParent=打开附件 -editor.toolbar.settings.export=导出笔记... +editor.toolbar.settings.export=导出当前笔记... editor.toolbar.settings.refreshSyncing=立即同步 alert.notValidCollectionError=请选择一个有效的分类。 alert.notValidParentItemError=无效的父条目。 +alert.notValidWorkspaceNote=工作区笔记未设置。创建一个吗？ diff --git a/src/modules/workspace/content.ts b/src/modules/workspace/content.ts index 867d136..d78a384 100644 --- a/src/modules/workspace/content.ts +++ b/src/modules/workspace/content.ts @@ -270,8 +270,11 @@ export async function initWorkspaceEditor( } = {} ) { const noteItem = Zotero.Items.get(noteId); - if (!noteItem.isNote()) { - throw new Error("initNoteEditor: not a note item"); + if (!noteItem || !noteItem.isNote()) { + if (window.confirm(getString("alert.notValidWorkspaceNote"))) { + await addon.hooks.onCreateWorkspaceNote(); + } + return; } const editorElem = container?.querySelector( `#${makeId("editor-" + type)}`