From 5a4bdc72bfb496fcf4dbea2f069d0ecccd320827 Mon Sep 17 00:00:00 2001 From: windingwind <33902321+windingwind@users.noreply.github.com> Date: Wed, 26 Jul 2023 21:32:03 +0800 Subject: [PATCH] fix: editor menu resizeImage duplication bug --- src/modules/editor/menu.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/modules/editor/menu.ts b/src/modules/editor/menu.ts index 2b9a812..d9eb69b 100644 --- a/src/modules/editor/menu.ts +++ b/src/modules/editor/menu.ts @@ -15,10 +15,14 @@ export function initEditorMenu(editor: Zotero.EditorInstance) { } editor._popup.setAttribute("bn-init", "true"); (editor._popup as XUL.Menu).addEventListener("popupshowing", (ev) => { - if (isImageAtCursor(editor)) { + const menuitemID = makeId("resizeImage"); + if ( + !(editor._popup as XUL.Menu).querySelector(`#${menuitemID}`) && + isImageAtCursor(editor) + ) { ztoolkit.Menu.register(editor._popup, { tag: "menuitem", - id: makeId("resizeImage"), + id: menuitemID, classList: [config.addonRef], label: getString("menuEditor.resizeImage"), icon: `chrome://${config.addonRef}/content/icons/favicon.png`,