From 7f3c754c0776729a60ef4dd765bd11eae36814bd Mon Sep 17 00:00:00 2001
From: windingwind <33902321+windingwind@users.noreply.github.com>
Date: Mon, 24 Jun 2024 12:16:50 +0800
Subject: [PATCH] add: open note as window by default option

---
 addon/chrome/content/preferences.xhtml | 5 +++++
 addon/locale/en-US/preferences.ftl     | 4 ++--
 addon/locale/it-IT/preferences.ftl     | 4 ++--
 addon/locale/ru-RU/preferences.ftl     | 4 ++--
 addon/locale/tr-TR/preferences.ftl     | 4 ++--
 addon/locale/zh-CN/preferences.ftl     | 4 ++--
 addon/prefs.js                         | 1 +
 src/modules/viewItems.ts               | 6 +++++-
 8 files changed, 21 insertions(+), 11 deletions(-)

diff --git a/addon/chrome/content/preferences.xhtml b/addon/chrome/content/preferences.xhtml
index 95eabdb..0ede4bb 100644
--- a/addon/chrome/content/preferences.xhtml
+++ b/addon/chrome/content/preferences.xhtml
@@ -12,6 +12,11 @@
       native="true"
       preference="__prefsPrefix__.openNote.takeover"
     />
+    <checkbox
+      data-l10n-id="basic-openNote-defaultAsWindow"
+      native="true"
+      preference="__prefsPrefix__.openNote.defaultAsWindow"
+    />
   </groupbox>
   <groupbox>
     <label><html:h2 data-l10n-id="editor-title"></html:h2></label>
diff --git a/addon/locale/en-US/preferences.ftl b/addon/locale/en-US/preferences.ftl
index a03d9ca..80294c9 100644
--- a/addon/locale/en-US/preferences.ftl
+++ b/addon/locale/en-US/preferences.ftl
@@ -1,8 +1,8 @@
 basic-title = Basic
 basic-openNote-takeover =
     .label = Take over opening note
-basic-related-takeover =
-    .label = Take over note relation
+basic-openNote-defaultAsWindow =
+    .label = Open note as window by default
 
 editor-title = Note Editor
 editor-expandLevel-label = Outline expand to heading level
diff --git a/addon/locale/it-IT/preferences.ftl b/addon/locale/it-IT/preferences.ftl
index b6b0c46..2a911af 100644
--- a/addon/locale/it-IT/preferences.ftl
+++ b/addon/locale/it-IT/preferences.ftl
@@ -1,8 +1,8 @@
 basic-title = Basic
 basic-openNote-takeover =
     .label = Take over opening note
-basic-related-takeover =
-    .label = Take over note relation
+basic-openNote-defaultAsWindow =
+    .label = Open note as window by default
 
 editor-title = Note Editor
 editor-expandLevel-label = Espansione dello schema al livello delle intestazioni
diff --git a/addon/locale/ru-RU/preferences.ftl b/addon/locale/ru-RU/preferences.ftl
index edbccee..45b7545 100644
--- a/addon/locale/ru-RU/preferences.ftl
+++ b/addon/locale/ru-RU/preferences.ftl
@@ -1,8 +1,8 @@
 basic-title = Basic
 basic-openNote-takeover =
     .label = Take over opening note
-basic-related-takeover =
-    .label = Take over note relation
+basic-openNote-defaultAsWindow =
+    .label = Open note as window by default
 
 editor-title = Note Editor
 editor-expandLevel-label = Outline расширить до уровня заголовка
diff --git a/addon/locale/tr-TR/preferences.ftl b/addon/locale/tr-TR/preferences.ftl
index a23410d..58e135b 100644
--- a/addon/locale/tr-TR/preferences.ftl
+++ b/addon/locale/tr-TR/preferences.ftl
@@ -1,8 +1,8 @@
 basic-title = Basic
 basic-openNote-takeover =
     .label = Take over opening note
-basic-related-takeover =
-    .label = Take over note relation
+basic-openNote-defaultAsWindow =
+    .label = Open note as window by default
 
 editor-title = Note Editor
 editor-expandLevel-label = Anahat başlık seviyesine genişletildi
diff --git a/addon/locale/zh-CN/preferences.ftl b/addon/locale/zh-CN/preferences.ftl
index 036ed83..c105369 100644
--- a/addon/locale/zh-CN/preferences.ftl
+++ b/addon/locale/zh-CN/preferences.ftl
@@ -1,8 +1,8 @@
 basic-title = 基本
 basic-openNote-takeover =
     .label = 接管打开笔记
-basic-related-takeover =
-    .label = 接管笔记关联
+basic-openNote-defaultAsWindow =
+    .label = 默认在窗口打开笔记
 
 editor-title = 笔记编辑器
 editor-expandLevel-label = 大纲展开至标题层级
diff --git a/addon/prefs.js b/addon/prefs.js
index 0db33c5..52f49b5 100644
--- a/addon/prefs.js
+++ b/addon/prefs.js
@@ -29,3 +29,4 @@ pref("__prefsPrefix__.workspace.outline.expandLevel", 2);
 pref("__prefsPrefix__.workspace.outline.keepLinks", true);
 
 pref("__prefsPrefix__.openNote.takeover", true);
+pref("__prefsPrefix__.openNote.defaultAsWindow", false);
diff --git a/src/modules/viewItems.ts b/src/modules/viewItems.ts
index e2c4ea8..318a302 100644
--- a/src/modules/viewItems.ts
+++ b/src/modules/viewItems.ts
@@ -1,4 +1,5 @@
 import { PatchHelper } from "zotero-plugin-toolkit/dist/helpers/patch";
+import { getPref } from "../utils/prefs";
 
 export function patchViewItems(win: Window) {
   // @ts-ignore
@@ -15,7 +16,10 @@ export function patchViewItems(win: Window) {
         const otherItems = [];
         for (const item of items) {
           if (item.isNote()) {
-            addon.hooks.onOpenNote(item.id, "tab");
+            addon.hooks.onOpenNote(
+              item.id,
+              getPref("openNote.defaultAsWindow") ? "window" : "tab",
+            );
             continue;
           }
           otherItems.push(item);