From 9a1200b585aa030ae85975ff326baeb119431f32 Mon Sep 17 00:00:00 2001 From: xiangyu <3170102889@zju.edu.cn> Date: Sun, 22 May 2022 00:43:30 +0800 Subject: [PATCH] fix: workspace template menu bug --- package.json | 2 +- src/views.ts | 18 +++++++++++------- update.rdf | 2 +- 3 files changed, 13 insertions(+), 9 deletions(-) diff --git a/package.json b/package.json index afd4af5..6910476 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,7 @@ "addonName": "Zotero Better Notes", "addonID": "Knowledge4Zotero@windingwind.com", "addonRef": "Knowledge4Zotero", - "version": "0.3.0", + "version": "0.3.1", "description": "Everything about note management. All in Zotero.", "main": "src/index.js", "scripts": { diff --git a/src/views.ts b/src/views.ts index f8a049a..c7323eb 100644 --- a/src/views.ts +++ b/src/views.ts @@ -648,13 +648,17 @@ class AddonViews extends AddonBase { const menuitem = _window.document.createElement("menuitem"); menuitem.setAttribute("id", template.name); menuitem.setAttribute("label", template.name); - menuitem.addEventListener("click", (e) => { - this._Addon.events.onEditorEvent( - new EditorMessage(`insert${type}UsingTemplate`, { - params: { templateName: template.name }, - }) - ); - }); + menuitem.setAttribute( + "oncommand", + ` + Zotero.Knowledge4Zotero.events.onEditorEvent({ + type: "insert${type}UsingTemplate", + content: { + params: { templateName: "${template.name}" }, + }, + });` + ); + if (template.disabled) { menuitem.setAttribute("disabled", true); } diff --git a/update.rdf b/update.rdf index 7ba65f8..0164c67 100644 --- a/update.rdf +++ b/update.rdf @@ -5,7 +5,7 @@ - 0.3.0 + 0.3.1 zotero@chnm.gmu.edu