blue
/
search-plugins-qbit-torrent
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drop leading zero ('0') from plugin minor version (#135) 

Four search plugins specify a leading zero in their minor version (e.g. `jackett: 3.03`). This leading zero isn't reflected in the qBittorrent GUI or the Web UI. This is because qBittorrent's version display logic [0] effectively drops the leading zero when calling `QString::number()`. Given that semver rule 2 [1] expressely forbids leading zeros, I don't consider qBittorrent's implementation a bug. Thus, we might as well drop the leading zero from those version numbers.

[0] 8999f1a8da/src/base/utils/version.h (L115),L129
[1] https://semver.org/#spec-item-2
This commit is contained in:
Tom Piccirello 2020-05-03 05:22:46 -07:00 committed by GitHub
parent 7ca82920ad
commit e0303cff4e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nova/engines/jackett.py
View File

@ -1,4 +1,4 @@
#VERSION: 3.03
#VERSION: 3.4
# AUTHORS: Diego de las Heras (ngosang@hotmail.es)
# CONTRIBUTORS: ukharley
# hannsen (github.com/hannsen)

2
nova/engines/leetx.py
View File

@ -1,4 +1,4 @@
#VERSION: 2.01
#VERSION: 2.2
#AUTHORS: Vikas Yadav (https://github.com/v1k45 | http://v1k45.com)
#CONTRIBUTORS: Diego de las Heras (ngosang@hotmail.es)

2
nova/engines/legittorrents.py
View File

@ -1,4 +1,4 @@
#VERSION: 2.03
#VERSION: 2.4
# AUTHORS: Christophe Dumez (chris@qbittorrent.org)
# Douman (custparasite@gmx.se)

2
nova/engines/limetorrents.py
View File

@ -1,4 +1,4 @@
#VERSION: 4.04
#VERSION: 4.5
# AUTHORS: Lima66
# CONTRIBUTORS: Diego de las Heras (ngosang@hotmail.es)

8
nova/engines/versions.txt
View File

@ -1,8 +1,8 @@
eztv: 1.10
jackett: 3.03
leetx: 2.01
legittorrents: 2.03
limetorrents: 4.04
jackett: 3.4
leetx: 2.2
legittorrents: 2.4
limetorrents: 4.5
piratebay: 2.20
rarbg: 2.12
torlock: 2.1

2
nova3/engines/jackett.py
View File

@ -1,4 +1,4 @@
#VERSION: 3.03
#VERSION: 3.4
# AUTHORS: Diego de las Heras (ngosang@hotmail.es)
# CONTRIBUTORS: ukharley
# hannsen (github.com/hannsen)

2
nova3/engines/leetx.py
View File

@ -1,4 +1,4 @@
#VERSION: 2.01
#VERSION: 2.2
#AUTHORS: Vikas Yadav (https://github.com/v1k45 | http://v1k45.com)
#CONTRIBUTORS: Diego de las Heras (ngosang@hotmail.es)

2
nova3/engines/legittorrents.py
View File

@ -1,4 +1,4 @@
#VERSION: 2.03
#VERSION: 2.4
# AUTHORS: Christophe Dumez (chris@qbittorrent.org)
# Douman (custparasite@gmx.se)

2
nova3/engines/limetorrents.py
View File

@ -1,4 +1,4 @@
#VERSION: 4.04
#VERSION: 4.5
# AUTHORS: Lima66
# CONTRIBUTORS: Diego de las Heras (ngosang@hotmail.es)

8
nova3/engines/versions.txt
View File

@ -1,8 +1,8 @@
eztv: 1.10
jackett: 3.03
leetx: 2.01
legittorrents: 2.03
limetorrents: 4.04
jackett: 3.4
leetx: 2.2
legittorrents: 2.4
limetorrents: 4.5
piratebay: 2.20
rarbg: 2.12
torlock: 2.1