fix: editor menu resizeImage duplication bug

2023-07-26 21:32:03 +08:00 · 2023-07-26 21:32:03 +08:00 · 5a4bdc72bf
parent 98636bca00
commit 5a4bdc72bf
1 changed files with 6 additions and 2 deletions
--- a/src/modules/editor/menu.ts
+++ b/src/modules/editor/menu.ts
@ -15,10 +15,14 @@ export function initEditorMenu(editor: Zotero.EditorInstance) {
  }
  editor._popup.setAttribute("bn-init", "true");
  (editor._popup as XUL.Menu).addEventListener("popupshowing", (ev) => {
-    if (isImageAtCursor(editor)) {
+    const menuitemID = makeId("resizeImage");
+    if (
+      !(editor._popup as XUL.Menu).querySelector(`#${menuitemID}`) &&
+      isImageAtCursor(editor)
+    ) {
      ztoolkit.Menu.register(editor._popup, {
        tag: "menuitem",
-        id: makeId("resizeImage"),
+        id: menuitemID,
        classList: [config.addonRef],
        label: getString("menuEditor.resizeImage"),
        icon: `chrome://${config.addonRef}/content/icons/favicon.png`,